Bugfix in bdd::as_expr #4279
Merged
Bugfix in bdd::as_expr #4279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in the way complement is computed when going to the then_branch.
romainbrenguier
requested review from
kroening,
martin-cs,
peterschrammel and
tautschnig
as code owners
romainbrenguier
force-pushed
the
bugfix/bdd_as_expr
branch
from
0b5a691 to
cb1e165
Compare
tautschnig
approved these changes
Feb 25, 2019
unit/solvers/prop/bdd_expr.cpp
Outdated
| { | ||
| const bool correct = result == and_exprt(a, not_exprt(b)) || | ||
| result == and_exprt(not_exprt(b), a); | ||
| REQUIRE(correct); |
There was a problem hiding this comment.
I'd break this up into four REQUIRE statements to obtain more meaningful output in case of failure:
REQUIRE(result.id() == ID_and);
REQUIRE(result.operands().size() == 2);
REQUIRE(result.op0() == a || result.op1() == a);
REQUIRE(result.op0() == not_exprt(b) || result.op1() == not_exprt(b));
|
It's actually failing CI, though... |
This adds a test case to check there are no mistakes in the BDD to expr conversions. This test can fail without the previous fix.
romainbrenguier
force-pushed
the
bugfix/bdd_as_expr
branch
from
cb1e165 to
e1fb6b7
Compare
|
@tautschnig fixed |
allredj
reviewed
Feb 25, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: e1fb6b7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102204954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the as_expr method. I also added a unit test that should fail without the fix.