Enable cbmc-concurrency regression tests by default #4278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
enable-concurrency-tests
branch
2 times, most recently
from
0f4916b to
4603c31
Compare
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
force-pushed
the
enable-concurrency-tests
branch
2 times, most recently
from
5c38005 to
b581af3
Compare
allredj
reviewed
Feb 25, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: b581af3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102230249
smowton
approved these changes
Feb 26, 2019
|
|
||
| ifeq ($(filter-out OSX MSVC,$(BUILD_ENV_)),) | ||
| # no POSIX threads on Windows | ||
| # for OSX we'd need sound handling of pointers in multi-threaded programs |
There was a problem hiding this comment.
? Why is that concern particular to OSX?
There was a problem hiding this comment.
I believe the difference is whether pthreadt is a typedef for a pointer type or not, which varies from platform to platform.
For some reason we had not included these in our standard set of regression tests, and sure enough they got out of sync and one actual regression happened.
Using it->code.set(ID_statement, ...) no longer suffices as it will not set code.id(), which is ID_nil after initialisation. Thus any such instruction is removed during goto-program cleanup. Use the recently added APIs instead, which will ensure proper initialisation.
They all fail with "pointer handling for concurrency is unsound."
tautschnig
force-pushed
the
enable-concurrency-tests
branch
from
b581af3 to
78437a1
Compare
allredj
reviewed
Feb 26, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 78437a1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102316841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we had not included these in our standard set of regression
tests, and sure enough they got out of sync and one actual regression happened.