Skip to content

Remove replace_all string utility #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

tautschnig
Copy link
Collaborator

There are several reasons why we should not maintain this here:

  • We do not have a single use in the code base.
  • It's completely unrelated to program analysis or any other CBMC matter.
  • If anyone else uses it, they are more than welcome to copy the implementation.
  • It was based on MIT-licensed code copyrighted by an external author. Mixing
    licenses within individual files is questionable practice.

I believe this is still used by TG, and I would thus suggest to copy the implementation into that repository.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There are several reasons why we should not maintain this here:
* We do not have a single use in the code base.
* It's completely unrelated to program analysis or any other CBMC matter.
* If anyone else uses it, they are more than welcome to copy the implementation.
* It was based on MIT-licensed code copyrighted by an external author. Mixing
  licenses within individual files is questionable practice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@thk123
Copy link
Contributor

thk123 commented Feb 25, 2019

Is indeed used in a few places but certainly can be copied - as per new process this can be merged though and we'll fix in due course.

@tautschnig tautschnig merged commit f9edf73 into diffblue:develop Feb 25, 2019
@tautschnig tautschnig deleted the remove-replace_all branch February 25, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants