Skip to content

Detect use of free() with alloca-allocated objects #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

Detect use of free() with alloca-allocated objects #4270

merged 1 commit into from
Feb 25, 2019

Conversation

tautschnig
Copy link
Collaborator

As we internally use dynamic allocation, we previously did not distinguish
alloca-allocated from malloc/calloc-allocated ones.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig mentioned this pull request Feb 24, 2019
Closed
13 tasks
@tautschnig tautschnig force-pushed the alloca-free branch 2 times, most recently from e42333e to 5b66bbb Compare February 25, 2019 00:40
@tautschnig tautschnig changed the title Detect use of free() with alloca-allocated objects Detect use of free() with alloca-allocated objects [depends-on: #4269] Feb 25, 2019
@tautschnig
Copy link
Collaborator Author

Requires #4269 for tests to pass on Windows.

kroening
kroening reviewed Feb 25, 2019
View reviewed changes
regression/cbmc/function-return-no-body1/test.desc
<function_call hidden="false" step_nr="18" thread="0">\n\s*<function display_name="no_body" identifier="no_body">
<function_return hidden="false" step_nr="19" thread="0">\n\s*<function display_name="no_body" identifier="no_body">
<function_call hidden="false" step_nr="19" thread="0">\n\s*<function display_name="no_body" identifier="no_body">
<function_return hidden="false" step_nr="20" thread="0">\n\s*<function display_name="no_body" identifier="no_body">
--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the step_nr really important? Perhaps make .*?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, now using \d+.

@tautschnig tautschnig changed the title Detect use of free() with alloca-allocated objects [depends-on: #4269] Detect use of free() with alloca-allocated objects Feb 25, 2019
@tautschnig
Detect use of free() with alloca-allocated objects
3c3348a 
As we internally use dynamic allocation, we previously did not distinguish
alloca-allocated from malloc/calloc-allocated ones.
allredj
allredj reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: f8b1563).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102138977
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig merged commit bbb1ce8 into diffblue:develop Feb 25, 2019
@tautschnig tautschnig deleted the alloca-free branch February 25, 2019 12:14
allredj
allredj reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 3c3348a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102146573
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig mentioned this pull request Feb 25, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@tautschnig tautschnig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @kroening @allredj @peterschrammel