Consider properties of inline functions #4260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
kroening,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
It looks like I should have done a better job in #3308... Approving, but note that CI is failing.
peterschrammel
force-pushed
the
fix-set-properties-inline
branch
from
f579e61 to
ee51719
Compare
Properties in inline functions used to be ignored because we ran partial_inline to inline them. Since we are not doing that anymore, properties in inline functions have been ignored without this fix. Inline functions are handled as any other functions now
peterschrammel
force-pushed
the
fix-set-properties-inline
branch
from
ee51719 to
ffd6d38
Compare
allredj
reviewed
Mar 3, 2019
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: ffd6d38).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102967269
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties in inline functions used to be discarded because we ran partial_inline. However, since we do not run partial_inline anymore, properties in inline functions would be completely ignored without this fix.