Skip to content

Add Owen as code owner to analyses, pointer-analysis #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

tautschnig
Copy link
Collaborator

Owen has already been an active reviewer despite not being a named code owner.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a sensible addition to me.

@tautschnig
Copy link
Collaborator Author

We will need #4255 to make CI happy again.

@tautschnig tautschnig self-assigned this Feb 22, 2019
The patterns were being used without anchoring to the beginning or end of the
line.
Owen has already been an active reviewer despite not being a named code owner.
@tautschnig tautschnig merged commit eabc411 into diffblue:develop Feb 22, 2019
@tautschnig tautschnig deleted the codeowners branch February 22, 2019 12:33
tautschnig added a commit that referenced this pull request Feb 22, 2019
Fix exit/signal specifications in enum-trace1 [blocks: #4253]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants