Local bitvector analysis: use parameter_identifiers [blocks: #4167]

[tautschnig]

goto_functiont::type will go away.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[smowton]

Suggestion for the future: when editing old code like this much of the change is just modernisation of for-loops, style improvement and so on. At least for review, how about two commits, one purely style and one that makes the real change?

[allredj]

✔️
Passed Diffblue compatibility checks (cbmc commit: 92e41bc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102435916

[allredj]

✔️
Passed Diffblue compatibility checks (cbmc commit: 4193829).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102908293