Skip to content

Remove unused includes list, functional from expr.h #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Remove unused includes list, functional from expr.h #4244

merged 1 commit into from
Feb 21, 2019

Conversation

tautschnig
Copy link
Collaborator

This header file is widely used, and dragging in useless includes unnecessarily
slows down compilation.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
Copy link
Member

ansi_c_convert_type.h will need a list include.

@tautschnig tautschnig self-assigned this Feb 21, 2019
@tautschnig tautschnig force-pushed the include-cleanup branch 2 times, most recently from 82ac0c7 to c2dca18 Compare February 21, 2019 11:34
@tautschnig
Remove unused includes list, functional from expr.h
df18307 
This header file is widely used, and dragging in useless includes unnecessarily
slows down compilation. Required fixes to files that actually do use std::list,
which in turn invited further cleanup of includes.
@tautschnig tautschnig merged commit 28f61dc into diffblue:develop Feb 21, 2019
@tautschnig tautschnig deleted the include-cleanup branch February 21, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

@owen-mc-diffblue owen-mc-diffblue owen-mc-diffblue approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

Assignees

@tautschnig tautschnig

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @kroening @owen-mc-diffblue