Skip to content

Remove deprecated irept::get_unsigned_int #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

tautschnig
Copy link
Collaborator

It has been deprecated since 06/2018 and has no users. This enables removing the
deprecate.h include. Also clean up an outdated NOLINT.

(Of course inspired by #4236.)

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
Copy link
Member

Do we want to form a view how long something needs to be deprecated to get deleted?
Do we have something like 'lives until release X'?
Could be made dependent on effort to refactor.

@tautschnig
Copy link
Collaborator Author

Do we want to form a view how long something needs to be deprecated to get deleted?

Some time ago you suggested it should be at least 6 months, so that's what I'm currently using as my guideline. But also I agree that the cost for downstream users should be taken into account, i.e., if it requires a lot of change then we ought to give people more time.

@tautschnig tautschnig self-assigned this Feb 21, 2019
It has been deprecated since 06/2018 and has no users. This enables removing the
deprecate.h include from irep.h (and makes obvious where the include actually is
needed).  Also clean up an outdated NOLINT.
@tautschnig tautschnig force-pushed the irep-deprecated-cleanup branch from 66e4d21 to 046a8c3 Compare February 21, 2019 09:31
@tautschnig tautschnig merged commit 54c5ff2 into diffblue:develop Feb 21, 2019
@tautschnig tautschnig deleted the irep-deprecated-cleanup branch February 21, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants