Skip to content

Fix array constraints for with_exprt with >3 operands [blocks: #2068] #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix array constraints for with_exprt with >3 operands [blocks: #2068] #4232

merged 1 commit into from
Feb 21, 2019

Conversation

tautschnig
Copy link
Collaborator

The initial support for more than 3 operands in 02e508e generated possibly
inconsistent constraints.

The test is based on SV-COMP's array-memsafety/count_down_unsafe_false-valid-deref.c.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

smowton
smowton reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some out of date comments that still talk in terms of a single operand with

smowton
smowton reviewed Feb 20, 2019
View reviewed changes
src/solvers/flattening/arrays.cpp Outdated
const index_sett &index_set,
const with_exprt &expr,
const exprt &index,
const exprt &value)
{
// we got x=(y with [i:=v])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of date

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

src/solvers/flattening/arrays.cpp Outdated
lazy_typet::ARRAY_WITH, equal_exprt(index_expr, value));
add_array_constraint(lazy, false); // added immediately

updated_indices.insert(index);
}

// use other array index applications for "else" case
// add constraint x[I]=y[I] for I!=i
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of date

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated.

@tautschnig
Fix array constraints for with_exprt with >3 operands
b7bb6a1 
The initial support for more than 3 operands in 02e508e generated possibly
inconsistent constraints. Also update comments to describe multiple update
operands.

The test is based on SV-COMP's array-memsafety/count_down_unsafe_false-valid-deref.c.
@tautschnig tautschnig merged commit c09e2a6 into diffblue:develop Feb 21, 2019
@tautschnig tautschnig deleted the array-fixup branch February 21, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

Assignees

@kroening kroening

@peterschrammel peterschrammel

@martin-cs martin-cs

Labels
blocker bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tautschnig @smowton @peterschrammel @kroening @martin-cs