Fix C enum output #4226
Merged
Fix C enum output #4226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
kroening,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Feb 18, 2019
| if(src.type().id() == ID_c_enum) | ||
| width = to_bitvector_type(to_c_enum_type(src.type()).subtype()).get_width(); | ||
| else | ||
| width = to_bitvector_type(src.type()).get_width(); |
There was a problem hiding this comment.
This will still fail if you have an ID_c_enum_tag... I'd actually use pointer_offset_bits to compute the width.
allredj
reviewed
Feb 19, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: f9b3690).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101379672
peterschrammel
force-pushed
the
fix-c-enum-output
branch
from
f9b3690 to
11f1a93
Compare
The subtype must be used.
bvrep2integer must be used.
peterschrammel
force-pushed
the
fix-c-enum-output
branch
from
11f1a93 to
7fa0f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the basic bugs that cause crashes at the moment.
Going forward this to-string-conversion code needs a complete overhaul as we are currently fixing the same bugs in three different places.
Tests coming...