Skip to content

Fix JSON goals output #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Feb 18, 2019

This was already broken in bmc_cover.

Test coming... Added

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 48b9ce6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101378066

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once test added

@peterschrammel peterschrammel force-pushed the fix-json-goals-output branch 2 times, most recently from 4e2e646 to b7aabee Compare February 21, 2019 21:44
@peterschrammel peterschrammel force-pushed the fix-json-goals-output branch from b7aabee to eb57043 Compare March 3, 2019 20:46
This was already broken in bmc_cover.
Goals need to be in an array and the summary counts
must be outside the array.
@peterschrammel peterschrammel force-pushed the fix-json-goals-output branch from eb57043 to e25a085 Compare March 3, 2019 21:39
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: e25a085).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102971852
Status will be re-evaluated on next push.
Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)

  • the author is not in the list of contributors (e.g. first-time contributors).

  • the compatibility was already broken by an earlier merge.

@peterschrammel peterschrammel merged commit 22d87d5 into diffblue:develop Mar 4, 2019
@peterschrammel peterschrammel deleted the fix-json-goals-output branch March 4, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants