Skip to content

expr2bits needs to handle pointer case #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2019
Merged

expr2bits needs to handle pointer case #4211

merged 1 commit into from
Feb 17, 2019

Conversation

kroening
Copy link
Member

This fixes #4168. The pointer case was not handled.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test has a further problem (I should have noticed when reviewing...): it needs 's/#include <stddef.h>/#include <stdlib.h>/'. Then CI should be happy.

@kroening
Copy link
Member Author

@tautschnig Yes, but that problem's a bug. I'll add the #include for this test, and will make a new one without.

@kroening kroening assigned tautschnig and unassigned kroening Feb 17, 2019
kroening pushed a commit that referenced this pull request Feb 17, 2019
Follow up from #4211.  The type of function symbols must get fixed once the
function signature is known.
kroening pushed a commit that referenced this pull request Feb 17, 2019
Follow up from #4211.  The type of function symbols must get fixed once the
function signature is known.
kroening pushed a commit that referenced this pull request Feb 17, 2019
Follow up from #4211.  The type of function symbols must get fixed once the
function signature is known.
This fixes #4168. The pointer case was not handled.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0c22c03).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101218184

@kroening kroening merged commit bff0c7e into develop Feb 17, 2019
@kroening kroening deleted the fix4168 branch February 17, 2019 10:48
kroening pushed a commit that referenced this pull request Feb 17, 2019
Follow up from #4211.  The type of function symbols must get fixed once the
function signature is known.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: CBMC crashes because it passes the string "NULL" get_bvrep_bit during symex
3 participants