Add test checking generic function parameter casts appear when expected #4200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
approved these changes
Feb 15, 2019
| @@ -0,0 +1,28 @@ | |||
|
|
|||
| public class test<T> { | |||
There was a problem hiding this comment.
Please capitalize class identifiers
smowton
force-pushed
the
smowton/cleanup/call-function-with-generic-parameter-test
branch
from
73e4933 to
3ffc34c
Compare
smowton
force-pushed
the
smowton/cleanup/call-function-with-generic-parameter-test
branch
from
3ffc34c to
7ec1023
Compare
allredj
reviewed
Feb 15, 2019
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 73e4933).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101128366
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
allredj
reviewed
Feb 15, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7ec1023).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101132412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for 3897b39, one of the type consistency fixes committed with #3822
These will get easier to express as and when
expr2javaprints generic type parameters / qualifiers, but I won't take that task on here, particularly because that means checking all consumers of pretty-printed output.