Skip to content

ssa_exprt::get_object_name: add fast path #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

tautschnig
Copy link
Collaborator

In many cases (without field sensitivity actually: always) the object will just
be the original expression, no further processing is required. Thus add a fast
path that handles this case directly, which reduces the cost from 967 seconds
across all of SV-COMP's ReachSafety-ECA down to 143 seconds.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

In many cases (without field sensitivity actually: always) the object will just
be the original expression, no further processing is required. Thus add a fast
path that handles this case directly, which reduces the cost from 967 seconds
across all of SV-COMP's ReachSafety-ECA down to 143 seconds.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 148fd45).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101009538

@tautschnig tautschnig merged commit c580d94 into diffblue:develop Feb 15, 2019
@tautschnig tautschnig deleted the get_object_name-fast branch February 15, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants