Java object factory: pass function ID to factory routine #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli and
thk123
as code owners
Previously this was accidentally dropped when used from the goto_functionst entry point.
smowton
force-pushed
the
smowton/fix/convert-nondet-function-id
branch
from
1dff4c3 to
8103468
Compare
allredj
reviewed
Feb 14, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8103468).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100913981
thk123
reviewed
Feb 14, 2019
There was a problem hiding this comment.
I don't understand this change. If The params.function_id needs to always be function_identifier, just drop the function_identifier parameter and set the field at the callsite? This feels like a weird fudge. Further - if this is fixing some broken behaviour, it needs a test.
NathanJPhillips
approved these changes
Feb 14, 2019
|
Discussed with @thk123 in person.
|
thk123
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was accidentally dropped when used from the goto_functionst entry point.