Generic tests: check for matching tag, not completely matching type #4172
Conversation
| @@ -28,6 +28,9 @@ require_pointer(const typet &type, const optionalt<typet> &subtype); | |||
| const struct_tag_typet & | |||
| require_struct_tag(const typet &type, const irep_idt &identifier = ""); | |||
|
|
|||
| const pointer_typet | |||
| require_pointer_to_tag(const typet &type, const irep_idt &identifier = ""); | |||
There was a problem hiding this comment.
Please use irep_idt() instead of "". (#4041 cleans this up for existing code.)
smowton
force-pushed
the
smowton/cleanup/generic-unit-test-type-checks
branch
from
138d2ff to
4866453
Compare
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 138d2ff).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100755208
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Previously these relied on base_type_eq to hide differently-decorated tags; now they explicitly just check the tag name, rather than relying on base_type_eq, which will soon go away anyway, to hide generic qualifiers and/or array element types.
smowton
force-pushed
the
smowton/cleanup/generic-unit-test-type-checks
branch
from
4866453 to
363d217
Compare
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 363d217).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100767719
Previously these relied on
base_type_eqto hide differently-decorated tags; after #4056 deletes that they will need to be explicit whether they seek an exact match or just to check the tag name.