String library preprocessor: use tag types, not expanded structs #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these we get assignments whose types match according to base_type_eq, but not operator==.
smowton
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli and
thk123
as code owners
tautschnig
approved these changes
Feb 13, 2019
|
Very possibly, but we're very close to getting #4056 mergeable so think we could just do this wholesale |
allredj
reviewed
Feb 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: c4ae7de).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100753205
thk123
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these we get assignments whose types match according to
base_type_eq, but notoperator==. Required for #4056.