Skip to content

Update CODEOWNERS #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Conversation

chrisr-diffblue
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue commented Feb 7, 2019

Add two new code owners for goto-analyzer and goto-instrument @danpoe and
@hannes-steffenhagen-diffblue. Also add @danpoe as an owner for src/analyses,
and add @chrisr-diffblue as an owner for .travis.yml

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Add two new code owners for goto-analyzer and goto-instrument @danpoe and
@hannes-steffenhagen-diffblue. Also add @danpoe as an owner for src/analyses,
and add @chrisr-diffblue as an owner for .travis.yml
CODEOWNERS Outdated
@@ -62,5 +62,5 @@
/scripts/delete_failing_smt2_solver_tests
/scripts/expected_doxygen_warnings.txt

/.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel
/.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel @chrisr-diffblue
/appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing that appveyor.yml line (possibly in a separate commit)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@chrisr-diffblue
Copy link
Contributor Author

Also added code owners for the new goto-harness tool in a separate commit.

We are not using Appveyor for Windows CI any more.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7c54057).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100123790

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b969f03).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100126150

@tautschnig tautschnig merged commit 85a2a6a into diffblue:develop Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants