String refinement: Do not fail if the solver returns a negative string length [blocks: #2574] #4113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
peterschrammel and
romainbrenguier
as code owners
romainbrenguier
approved these changes
Feb 7, 2019
| @@ -1213,6 +1213,12 @@ static exprt negation_of_not_contains_constraint( | |||
|
|
|||
| // The negated existential becomes an universal, and this is the unrolling of | |||
| // that universal quantifier. | |||
| // if the upper bound is smaller than the lower bound (specifically, it might | |||
There was a problem hiding this comment.
Upper case on the first letter
…g length The string length may initially be unconstrained, and such counterexamples should not result in failing invariants. When enabling field sensitivity, strings-smoke-tests/java_index_of2 was failing as the solver returned -1073741820 for string_refinement#string_length#1 (which is a signed integer).
tautschnig
force-pushed
the
fix-negation_of_not_contains_constraint
branch
from
b1b9410 to
14f542e
Compare
allredj
reviewed
Feb 7, 2019
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: b1b9410).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100074425
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
allredj
reviewed
Feb 7, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 14f542e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100078101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string length may initially be unconstrained, and such counterexamples
should not result in failing invariants. When enabling field sensitivity,
strings-smoke-tests/java_index_of2 was failing as the solver returned
-1073741820 for string_refinement#string_length#1 (which is a signed integer).