OpenBSD compatibility #4053
Merged
OpenBSD compatibility #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanolith
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Feb 3, 2019
kroening
reviewed
Feb 3, 2019
As per tautschnig's suggestion.
nanolith
commented
Feb 3, 2019
|
Is there anything else that the collaborators need from me for this PR? I just want to confirm that you didn't need anything else from my end. |
|
@nanolith Yes, please help |
|
Fixed all clang-format issues. All green. :-) |
allredj
reviewed
Feb 6, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3236da7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99968034
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches to support CBMC on OpenBSD.
The ansi-c library has been patched to provide a compatible pthread_barrier_init function, and to bypass OpenBSD's stdio.h, which can't currently be parsed by the checker script.
The c_preprocess.cpp source file in ansi-c has been patched to pass the appropriate -std to Clang on OpenBSD. OpenBSD does not use GNU extensions with the system Clang.
The config.cpp source file in util has been patched so that OpenBSD defaults to c99, just like FreeBSD.
Patches have been protected with a
defined(__OpenBSD__)check to ensure that they do not impact other builds.