Test for member type consistency [depends-on: #4021] #4023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
tautschnig
approved these changes
Feb 1, 2019
tautschnig
changed the title
thk123
approved these changes
Feb 1, 2019
tautschnig
changed the title
tautschnig
added a commit
that referenced
this pull request
Mar 7, 2019
…xpressions Verify member expressions [blocks: #4023]
smowton
force-pushed
the
smowton/admin/test-for-member-type-consistency
branch
from
a284810 to
b1efed4
Compare
|
Rebased |
allredj
reviewed
Mar 7, 2019
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: b1efed4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103549141
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #4021 and #4020 -- please only review the last commit. This adds a test for ec41608 which went in with @thk123's type consistency improvements -- revert that commit (requires reverting a few subsequent refactors) to see it fail.