-
Notifications
You must be signed in to change notification settings - Fork 274
Store goto_symex::\guard in a single place [blocks: #3619] #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7562b09).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99328913
7562b09
to
9eb1c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 9eb1c9b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99414751
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
@romainbrenguier confirmed that this passes TG tests. |
|
@tautschnig, maybe in a separate file? |
I should be able to put it in |
The static member of a static function will ensure both proper initialisation and making it available to all users.
9eb1c9b
to
58bd9ed
Compare
I have moved the declaration to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 58bd9ed).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99574553
The static member of a static function will ensure both proper initialisation
and making it available to all users.
This is factored out from #3619 to make it easier to pinpoint what exactly causes trouble with TG. The commit conflict-resolved version of the third one from #3619, which has been approved already.