vector_typet::size() is now a constant_exprt #4007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
2 tasks
smowton
approved these changes
Jan 31, 2019
tautschnig
approved these changes
Jan 31, 2019
| : type_with_subtypet(ID_vector, _subtype) | ||
| { | ||
| size() = _size; | ||
| } |
There was a problem hiding this comment.
What's the rationale to move these to the .cpp file?
There was a problem hiding this comment.
constant_exprt isn't complete -- there's a cyclic dependency between std_types.h and std_expr.h.
|
@tautschnig The problem is that there's a period of time in both front-ends where the expression isn't yet turned into a constant. I might have to introduce s.th. like |
kroening
force-pushed
the
vector_typet_size
branch
from
11f2cd1 to
d7150a1
Compare
|
Added ID_frontend_vector, similar to ID_frontend_pointer, for the type that's yet to be finished. |
kroening
force-pushed
the
vector_typet_size
branch
from
d7150a1 to
ab89f8f
Compare
added 2 commits
February 1, 2019 17:56
This enables distinguishing the case of a size that is an arbitary expression from the case where the size is required to be constant.
The codebase assumes basically globally that vector_typet::size() is a constant_exprt. This is now enforced by the signature.
tautschnig
force-pushed
the
vector_typet_size
branch
from
ab89f8f to
41e4913
Compare
allredj
reviewed
Feb 1, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 41e4913).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99471857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase assumes basically globally that vector_typet::size() is a
constant_exprt. This is now enforced by the signature.