Skip to content

Add overload of join_string() that takes a function argument #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented Jan 30, 2019

Add overload of join_string() that takes a function argument that it applies to the elements of the container it flattens and add tests for it.

This is work that we did jointly @hannes-steffenhagen-diffblue as part of the work on the goto-harness feature.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the same can be achieved by doing auto range = make_range(container).map(transformer); join_strings(stream, range.begin(), range.end(), delim); Is that good or bad?

@NlightNFotis NlightNFotis force-pushed the string_join_enhancement branch 4 times, most recently from 827b774 to 8698cdf Compare January 31, 2019 15:38
@NlightNFotis NlightNFotis force-pushed the string_join_enhancement branch 2 times, most recently from 2ccb645 to 2043660 Compare January 31, 2019 17:00
… of the container it flattens

and add tests for it.
@NlightNFotis NlightNFotis force-pushed the string_join_enhancement branch from 2043660 to f98cbed Compare February 1, 2019 11:29
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: f98cbed).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99416416
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@NlightNFotis NlightNFotis merged commit 178802d into diffblue:develop Feb 1, 2019
@NlightNFotis NlightNFotis deleted the string_join_enhancement branch February 1, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants