Skip to content

remove slice_by_trace feature #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions jbmc/src/jbmc/jbmc_parse_options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ void jbmc_parse_optionst::get_command_line_options(optionst &options)
if(cmdline.isset("debug-level"))
options.set_option("debug-level", cmdline.get_value("debug-level"));

if(cmdline.isset("slice-by-trace"))
options.set_option("slice-by-trace", cmdline.get_value("slice-by-trace"));

if(cmdline.isset("unwindset"))
options.set_option("unwindset", cmdline.get_value("unwindset"));

Expand Down
2 changes: 1 addition & 1 deletion jbmc/src/jbmc/jbmc_parse_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class optionst;
// clang-format off
#define JBMC_OPTIONS \
OPT_BMC \
"(preprocess)(slice-by-trace):" \
"(preprocess)" \
OPT_FUNCTIONS \
"(no-simplify)(full-slice)" \
OPT_REACHABILITY_SLICER \
Expand Down
3 changes: 0 additions & 3 deletions jbmc/src/jdiff/jdiff_parse_options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,6 @@ void jdiff_parse_optionst::get_command_line_options(optionst &options)
if(cmdline.isset("debug-level"))
options.set_option("debug-level", cmdline.get_value("debug-level"));

if(cmdline.isset("slice-by-trace"))
options.set_option("slice-by-trace", cmdline.get_value("slice-by-trace"));

if(cmdline.isset("unwindset"))
options.set_option("unwindset", cmdline.get_value("unwindset"));

Expand Down
5 changes: 4 additions & 1 deletion src/cbmc/cbmc_parse_options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,10 @@ void cbmc_parse_optionst::get_command_line_options(optionst &options)
options.set_option("debug-level", cmdline.get_value("debug-level"));

if(cmdline.isset("slice-by-trace"))
options.set_option("slice-by-trace", cmdline.get_value("slice-by-trace"));
{
error() << "--slice-by-trace has been removed" << eom;
exit(CPROVER_EXIT_USAGE_ERROR);
}

if(cmdline.isset("unwindset"))
options.set_option("unwindset", cmdline.get_value("unwindset"));
Expand Down
7 changes: 0 additions & 7 deletions src/goto-checker/bmc_util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ Author: Daniel Kroening, Peter Schrammel
#include <goto-symex/build_goto_trace.h>
#include <goto-symex/memory_model_pso.h>
#include <goto-symex/slice.h>
#include <goto-symex/slice_by_trace.h>
#include <goto-symex/symex_target_equation.h>

#include <linking/static_lifetime_init.h>
Expand Down Expand Up @@ -187,13 +186,7 @@ void slice(
ui_message_handlert &ui_message_handler)
{
messaget msg(ui_message_handler);
if(options.get_option("slice-by-trace") != "")
{
symex_slice_by_tracet symex_slice_by_trace(ns);

symex_slice_by_trace.slice_by_trace(
options.get_option("slice-by-trace"), symex_target_equation);
}
// any properties to check at all?
if(symex_target_equation.has_threads())
{
Expand Down
3 changes: 0 additions & 3 deletions src/goto-diff/goto_diff_parse_options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@ void goto_diff_parse_optionst::get_command_line_options(optionst &options)
if(cmdline.isset("debug-level"))
options.set_option("debug-level", cmdline.get_value("debug-level"));

if(cmdline.isset("slice-by-trace"))
options.set_option("slice-by-trace", cmdline.get_value("slice-by-trace"));

if(cmdline.isset("unwindset"))
options.set_option("unwindset", cmdline.get_value("unwindset"));

Expand Down
1 change: 0 additions & 1 deletion src/goto-symex/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ SRC = auto_objects.cpp \
show_program.cpp \
show_vcc.cpp \
slice.cpp \
slice_by_trace.cpp \
symex_assign.cpp \
symex_atomic_section.cpp \
symex_builtin_functions.cpp \
Expand Down
Loading