-
Notifications
You must be signed in to change notification settings - Fork 274
Restore namespace after symbolic execution [blocks: #3976] #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a61e04a
to
58e0f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 58e0f10).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98730024
@@ -242,12 +242,31 @@ void goto_symext::symex_with_state( | |||
const get_goto_functiont &get_goto_function, | |||
symbol_tablet &new_symbol_table) | |||
{ | |||
struct reset_namespacet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a one-liner explaining what this aims to achieve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
58e0f10
to
503e42f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 503e42f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98934307
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
503e42f
to
23196af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 23196af).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99024802
This was already fixed in d475abc, but 685937a introduced additional
returns. Now use an approach that will always work, even when returning via
exceptions being thrown.