Skip to content

Restore namespace after symbolic execution [blocks: #3976] #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

tautschnig
Copy link
Collaborator

This was already fixed in d475abc, but 685937a introduced additional
returns. Now use an approach that will always work, even when returning via
exceptions being thrown.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 58e0f10).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98730024

@tautschnig tautschnig changed the title Restore namespace after symbolic execution Restore namespace after symbolic execution [blocks: #3976] Jan 28, 2019
@@ -242,12 +242,31 @@ void goto_symext::symex_with_state(
const get_goto_functiont &get_goto_function,
symbol_tablet &new_symbol_table)
{
struct reset_namespacet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a one-liner explaining what this aims to achieve.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 503e42f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98934307
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

This was already fixed in d475abc, but 685937a introduced additional
returns. Now use an approach that will always work, even when returning via
exceptions being thrown.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 23196af).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99024802

@tautschnig tautschnig merged commit 0c6d6b2 into diffblue:develop Jan 30, 2019
@tautschnig tautschnig deleted the fix-3956-namespace branch January 30, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants