Skip to content

Fully rewrite nested forall during symbolic execution #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

tautschnig
Copy link
Collaborator

This permits (correctly) solving another simple regression test.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig changed the title Fully rewrite nested forall during symbolic execution Fully rewrite nested forall during symbolic execution [depends-on: #3724] Jan 24, 2019
@tautschnig tautschnig self-assigned this Jan 25, 2019
tautschnig added a commit that referenced this pull request Jan 28, 2019
Quantifier test: The second assertion does not hold [blocks: #2574, #3725, #3924]
This permits (correctly) solving another simple regression test.
@tautschnig tautschnig changed the title Fully rewrite nested forall during symbolic execution [depends-on: #3724] Fully rewrite nested forall during symbolic execution Jan 28, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 9351d80).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98787444

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the improving quality of quantification over bit-vectors, we might want to keep half a mind towards preserving quantifier structure where we can.

@peterschrammel peterschrammel removed their assignment Jan 28, 2019
@tautschnig tautschnig merged commit d4e627b into diffblue:develop Jan 28, 2019
@tautschnig tautschnig deleted the rewrite-forall branch January 28, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants