Use fieldref exprt #3915
Use fieldref exprt #3915
Conversation
thk123
requested review from
cesaro,
cristina-david,
kroening,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
| @@ -341,6 +341,22 @@ class fieldref_exprt : public exprt | |||
| set(ID_class, class_name); | |||
| set(ID_component_name, component_name); | |||
| } | |||
|
|
|||
| irep_idt field_of_class() const | |||
There was a problem hiding this comment.
this suggests this yields a field -- how about just class_name?
| /// components if necessary. | ||
| static member_exprt to_member( | ||
| const exprt &pointer, | ||
| const fieldref_exprt &field_instruction, |
There was a problem hiding this comment.
This isn't the instruction, rather it's its argument, so field_reference or just fieldref?
There was a problem hiding this comment.
Addressed in previous PR.
thk123
force-pushed
the
use-fieldref-exprt
branch
from
a6740e1 to
a654adb
Compare
thk123
force-pushed
the
use-fieldref-exprt
branch
from
a654adb to
60553c1
Compare
|
@smowton comments addressed. |
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: a654adb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99010646
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 60553c1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99011453
Uh oh!
There was an error while loading. Please reload this page.