Skip to content

Construct side_effect_expr_function_callt in a non-deprecated way [blocks: #3800] #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Construct side_effect_expr_function_callt in a non-deprecated way [blocks: #3800] #3907

merged 1 commit into from
Jan 30, 2019
+87 −86

Conversation

tautschnig
Copy link
Collaborator

The constructor requires four arguments.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

allredj
allredj reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: af8467a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98376413

smowton
smowton reviewed Jan 24, 2019
View reviewed changes
src/goto-instrument/goto_program2code.cpp
side_effect_expr_function_callt type_of;
type_of.function() =
symbol_exprt("__typeof__", code_typet({}, empty_typet()));
side_effect_expr_function_callt type_of(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we eventually get away with this apparently-wrong type? Comment here to say where the fixup takes place?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added (fixup never happens, we simply don't care).

@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch 2 times, most recently from a6ddfc3 to 4243502 Compare January 24, 2019 13:13
allredj
allredj reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 4243502).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98476947
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch 2 times, most recently from e3bd64e to 39dceb8 Compare January 25, 2019 10:29
@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch from 39dceb8 to f3f8933 Compare January 25, 2019 12:07
allredj
allredj reviewed Jan 25, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: f3f8933).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98607139
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch from f3f8933 to 7376880 Compare January 26, 2019 13:15
allredj
allredj reviewed Jan 26, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7376880).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98711807

martin-cs
martin-cs approved these changes Jan 28, 2019
View reviewed changes
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My parts are fine.

src/cpp/cpp_constructor.cpp Outdated

function_call.add_source_location()=source_location;
operands_tc,
typet(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default constructor for typet() really supported / the best option?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3941 introduces uninitialized_typet, which might be a better option. I'll make this PR depend on #3941.

@tautschnig tautschnig changed the title Construct side_effect_expr_function_callt in a non-deprecated way [blocks: #3800] Construct side_effect_expr_function_callt in a non-deprecated way [depends-on: #3941, blocks: #3800] Jan 28, 2019
@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch from 7376880 to ef2e826 Compare January 28, 2019 16:40
tautschnig added a commit that referenced this pull request Jan 28, 2019
@tautschnig
Merge pull request #3941 from tautschnig/deprecation-nil_typet-typech…
d2a0df9 
…ecking

Use typet instead of nil_typet during type checking [blocks: #3800, #3907]
@tautschnig tautschnig changed the title Construct side_effect_expr_function_callt in a non-deprecated way [depends-on: #3941, blocks: #3800] Construct side_effect_expr_function_callt in a non-deprecated way [blocks: #3800] Jan 28, 2019
@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch from ef2e826 to 7be76c4 Compare January 28, 2019 23:08
allredj
allredj reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 7be76c4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98896055
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig force-pushed the deprecation-side_eff_function_call branch from 7be76c4 to 28ea7a5 Compare January 29, 2019 18:15
allredj
allredj reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 28ea7a5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99028690

@tautschnig tautschnig merged commit c59500b into diffblue:develop Jan 30, 2019
@tautschnig tautschnig deleted the deprecation-side_eff_function_call branch January 30, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton left review comments

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

@martin-cs martin-cs martin-cs approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@tautschnig tautschnig

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tautschnig @smowton @kroening @martin-cs @allredj @peterschrammel @chrisr-diffblue