Skip to content

Construct complex_typet in a non-deprecated way [blocks: #3800] #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2019
Merged

Construct complex_typet in a non-deprecated way [blocks: #3800] #3903

merged 1 commit into from
Jan 24, 2019

Conversation

tautschnig
Copy link
Collaborator

The default constructor is deprecated.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner January 23, 2019 19:22
allredj
allredj reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 823c1c4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98370481

kroening
kroening reviewed Jan 24, 2019
View reviewed changes
src/ansi-c/literals/convert_integer_literal.cpp
from_integer(0, type), from_integer(value, type), complex_type);
from_integer(0, type),
from_integer(value, type),
std::move(complex_type));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nest the constructors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tautschnig
Construct complex_typet in a non-deprecated way
fd1d394 
The default constructor is deprecated.
@tautschnig tautschnig force-pushed the deprecation-complex_typet branch from 823c1c4 to fd1d394 Compare January 24, 2019 09:34
allredj
allredj reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: fd1d394).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98448294

@tautschnig tautschnig merged commit 3a7de29 into diffblue:develop Jan 24, 2019
@tautschnig tautschnig deleted the deprecation-complex_typet branch January 24, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

Assignees

@tautschnig tautschnig

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @kroening @allredj