Variable in test.desc file can be also separated by ':' or ';' #3889
Conversation
|
Sadly neither the commit message nor the PR description really enlighten me as to what is going on here? - perhaps a supporting example would help? |
|
Sorry @thk123. I've added an example to the description. |
regression/test.pl
Outdated
| @@ -74,6 +74,7 @@ ($$$$$$$$$$) | |||
| foreach my $key (@keys) { | |||
| my $value = $defines->{$key}; | |||
| $options =~ s/(\$$key$|\$$key )/$value /g; | |||
| $options =~ s/\$$key:/$value:/g; | |||
There was a problem hiding this comment.
For maintainability, I would love a comment to explain why we need the : as a separator, e.g.
# Variables in --classpath are separated by colons
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 9d9023a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98159435
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
forejtv
changed the title
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: f127bf4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98200668
To be able to use variables in
.descfiles also in the--classpathargument, we need to use:as a separator for variable names, currently the only separator is a space.For example, we want to be able to use a
.descfile in which the arguments have the following structure: