Use numeric_cast_v<unsigned> instead to_ulong with incompatible types [blocks: #3800] #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli and
smowton
as code owners
allredj
reviewed
Jan 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 894c5d4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98085490
kroening
reviewed
Jan 22, 2019
| @@ -1246,7 +1245,7 @@ float ieee_floatt::to_float() const | |||
| CHECK_RETURN(i.is_ulong()); | |||
| CHECK_RETURN(i <= std::numeric_limits<std::uint32_t>::max()); | |||
|
|
|||
| a.i=i.to_ulong(); | |||
| a.i = numeric_cast_v<unsigned>(i); | |||
| return a.f; | |||
There was a problem hiding this comment.
Use uint32_t instead of unsigned?
There was a problem hiding this comment.
Indeed, and will then remove the above CHECK_RETURN as numeric_cast_v subsumes these.
kroening
approved these changes
Jan 22, 2019
smowton
approved these changes
Jan 22, 2019
An unsigned need not be as wide as an unsigned long - make good use of numeric_cast instead.
tautschnig
force-pushed
the
deprecation-integer2unsigned
branch
from
894c5d4 to
7d95e60
Compare
tautschnig
assigned peterschrammel, martin-cs and chrisr-diffblue and unassigned tautschnig
allredj
reviewed
Jan 22, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7d95e60).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98164694
peterschrammel
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unsigned need not be as wide as an unsigned long - make good use of
numeric_cast instead.