Skip to content

Use optionalt<symbol_exprt> when it isn't always set [blocks: #3766] #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2019
Merged

Use optionalt<symbol_exprt> when it isn't always set [blocks: #3766] #3874

merged 2 commits into from
Jan 22, 2019

Conversation

tautschnig
Copy link
Collaborator

Avoids use of a deprecated constructor and makes more explicit whether the
symbol is or isn't set.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the symbol_exprt-optional branch 3 times, most recently from 863e0cf to 6975be9 Compare January 21, 2019 20:40
@tautschnig
Use optionalt<symbol_exprt> when it isn't always set
6b2b950 
Avoids use of a deprecated constructor and makes more explicit whether the
symbol is or isn't set.
@tautschnig tautschnig force-pushed the symbol_exprt-optional branch from 6975be9 to 8a8e42e Compare January 21, 2019 22:49
@tautschnig
Work around spurious warning raised up to GCC 6.5
f71df24 
GCC complains:

../util/irep.h:247:21: error: ‘*((void*)(& __val)+8).irept::data’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
     remove_ref(data);

GCC 7 and later are fine without this hack.
@tautschnig tautschnig force-pushed the symbol_exprt-optional branch from 8a8e42e to f71df24 Compare January 21, 2019 23:18
allredj
allredj reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f71df24).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98095627

@tautschnig tautschnig merged commit 7c844fb into diffblue:develop Jan 22, 2019
@tautschnig tautschnig deleted the symbol_exprt-optional branch January 22, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees
No one assigned
Labels
blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @smowton @kroening @allredj