Skip to content

Use hybrid_binary(...) to avoid code duplication [blocks: #3867] #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

tautschnig
Copy link
Collaborator

The implementation in as_mode.cpp was effectively doing the same, just using
different variable names.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The implementation in as_mode.cpp was effectively doing the same, just using
different variable names.
@tautschnig tautschnig requested a review from kroening as a code owner January 21, 2019 11:35
@tautschnig tautschnig mentioned this pull request Jan 21, 2019
5 tasks
@tautschnig tautschnig changed the title Use hybrid_binary(...) to avoid code duplication Use hybrid_binary(...) to avoid code duplication [blocks: #3867] Jan 21, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 951d809).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98025316

@kroening kroening merged commit 306fbf7 into diffblue:develop Jan 21, 2019
@tautschnig tautschnig deleted the refactor-hybrid_binary branch January 21, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants