Goto checker interface enhancements [blocks: 3794] #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
chrisr-diffblue,
kroening,
smowton and
tautschnig
as code owners
peterschrammel
force-pushed
the
goto-checker-interface-fixes
branch
from
ad3e568 to
4796e85
Compare
peterschrammel
changed the title
allredj
reviewed
Jan 20, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4796e85).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97958807
tautschnig
approved these changes
Jan 20, 2019
|
|
||
| // Outputs a proof in GraphML format (see `graphml_witnesst`) | ||
| virtual void output_proof() = 0; | ||
| virtual const namespacet &get_namespace() const = 0; |
There was a problem hiding this comment.
This change does not seem to relate to the commit message?
| virtual void output_error_witness(const goto_tracet &) = 0; | ||
|
|
||
| // Outputs a proof in GraphML format (see `graphml_witnesst`) | ||
| virtual void output_proof() = 0; |
There was a problem hiding this comment.
Missing virtual destructor.
| virtual goto_tracet build_trace() const = 0; | ||
|
|
||
| /// Returns the namespace associated with the traces | ||
| virtual const namespacet &get_namespace() const = 0; |
There was a problem hiding this comment.
Missing virtual destructor
| DONE | ||
| }; | ||
|
|
||
| progresst progress; |
There was a problem hiding this comment.
You might use progresst progress = DONE; and ...
| /// `incremental_goto_checkert::operator()` | ||
| std::vector<irep_idt> updated_properties; | ||
|
|
||
| resultt(); |
There was a problem hiding this comment.
... resultt() = default;
Not all incremental_goto_checkert implementations can provide witnesses.
Not all incremental goto checker implementations may support traces.
The goto verifier might want to know which properties have been updated in the last call to the incremental goto checker, e.g. to output status information or report results continuously.
peterschrammel
force-pushed
the
goto-checker-interface-fixes
branch
from
4796e85 to
be514e3
Compare
allredj
reviewed
Jan 20, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: be514e3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97968610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make witness output optional
Make returning traces optional
Return IDs of updated properties
Each commit message has a non-empty body, explaining why the change was made.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.