Skip to content

Disable loop-less init of primitive arrays #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

allredj
Copy link
Contributor

@allredj allredj commented Jan 17, 2019

Loop-less initialization seems to not play well with the trace interpreter.
This PR disables the feature and the tests.
The issue is not visible in JBMC.

Reverts the functionality of #3649

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This seems to not play very well with the interpreter at this point.
@allredj allredj force-pushed the disable-loopless-init branch from 771bf6d to 9ecd702 Compare January 17, 2019 13:03
Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 9ecd702).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97688681
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@allredj
Copy link
Contributor Author

allredj commented Jan 17, 2019

Replaced by #3827

@allredj allredj closed this Jan 17, 2019
@allredj allredj deleted the disable-loopless-init branch January 21, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant