Skip to content

Object factory string options parsing fixes #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2019
Merged

Object factory string options parsing fixes #3816

merged 3 commits into from
Jan 21, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Jan 15, 2019 •
edited
Loading

This moves object factory string options parsing into parse_object_factory_options(), and throws an invalid_command_line_argument_exceptiont for options that can't be used together instead of ignoring an option.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

tautschnig
tautschnig approved these changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just clang-format isn't happy yet.

@danpoe danpoe force-pushed the fixes/object-factory-string-input-options branch from e77b145 to a7c0df1 Compare January 17, 2019 11:07
allredj
allredj reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: a7c0df1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97675048
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@danpoe danpoe force-pushed the fixes/object-factory-string-input-options branch from a7c0df1 to b6c4eee Compare January 18, 2019 11:31
allredj
allredj reviewed Jan 18, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: b6c4eee).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97822433
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@danpoe danpoe force-pushed the fixes/object-factory-string-input-options branch from b6c4eee to a9a170c Compare January 21, 2019 12:08
danpoe added 3 commits January 21, 2019 12:08
@danpoe
Throw exception when using incompatible object factory string handlin…
8b69de0 
…g options

Throw an invalid_command_line_argument_exceptiont when using object factory
string handling options that don't both have an effect when used together
(rather than printing a warning and ignoring an option).
@danpoe
Use literal true instead of calling cmdline.isset() twice
06cdd2e
@danpoe
Move string handling option parsing to parse_object_factory_options()
a9a170c 
Two object factory options were currently parsed in jbmc_parse_optionst but
should be parsed by parse_object_factory_options() like the other options.
allredj
allredj reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: a9a170c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98037663

@danpoe danpoe merged commit 2746997 into diffblue:develop Jan 21, 2019
@danpoe danpoe deleted the fixes/object-factory-string-input-options branch June 2, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@tautschnig tautschnig tautschnig approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@danpoe danpoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danpoe @smowton @tautschnig @allredj