Construct with_exprt in a non-deprecated way #3780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
allredj
reviewed
Jan 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7566bbf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97156182
kroening
reviewed
Jan 13, 2019
| new_rhs.where().set(ID_component_name, component_name); | ||
| new_rhs.new_value()=rhs; | ||
| new_rhs.type() = new_lhs.type(); | ||
|
|
There was a problem hiding this comment.
The constructor already sets the type.
kroening
reviewed
Jan 13, 2019
| new_rhs.type()=new_lhs.type(); | ||
| new_rhs.old()=new_lhs; |
kroening
approved these changes
Jan 13, 2019
tautschnig
force-pushed
the
deprecation-with_exprt
branch
from
7566bbf to
5eec111
Compare
The default constructor is deprecated.
tautschnig
force-pushed
the
deprecation-with_exprt
branch
from
5eec111 to
7ddb548
Compare
allredj
reviewed
Jan 14, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7ddb548).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97293572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default constructor is deprecated.