Skip to content

Remove unnecessary use of ns.follow in flattening [blocks: #3652] #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

tautschnig
Copy link
Collaborator

Only structs, unions, enums can be hidden behind tags. And keeping symbol or tag
types in the mapping is just fine, there is no need to store the expanded
version.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Only structs, unions, enums can be hidden behind tags. And keeping symbol or tag
types in the mapping is just fine, there is no need to store the expanded
version.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: ee929f3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96866386

@smowton
Copy link
Contributor

smowton commented Jan 10, 2019

@chrisr-diffblue can you confirm if the Ada frontend uses ID_symbol_type for primitive / array types any more?

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me if Chris R confirms this won't break Ada

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we no longer use symbol types for Ada (if there are still any places we do, we'll fix them up the next time we do a submodule bump) so I'm happy for this to go in.

@kroening kroening merged commit d21a6bc into diffblue:develop Jan 11, 2019
@tautschnig tautschnig deleted the no-follow-2 branch January 11, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants