Remove unnecessary uses of ns.follow in util/ #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
Jan 9, 2019
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
|
Am I wrong then in thinking a typedef manifests as a symbol type? |
|
typedef names are stored in |
|
BTW, the need to use type_eq() should go away -- simply equality should work. |
tautschnig
force-pushed
the
remove-follow-in-util
branch
2 times, most recently
from
06b14ca to
994ecbc
Compare
This also makes the namespace unnecessary in three cases.
Using ns.follow on both sides of an operator== is better encapsulated in type_eq.
Neither arrays nor Booleans use tag types.
There is no need to use ns.follow when either 1) we only compare the result to types that can never be hidden behind tags or 2) the tag case is handled explicitly.
tautschnig
force-pushed
the
remove-follow-in-util
branch
from
994ecbc to
d48e62b
Compare
tautschnig
assigned smowton, kroening, peterschrammel and chrisr-diffblue and unassigned tautschnig
smowton
approved these changes
Jan 23, 2019
allredj
reviewed
Jan 23, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d48e62b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98329813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.