Move remove_asm.{h,cpp} to assembler/

[tautschnig]

Encapsulate assembler-related code in this folder, and make those driver
programs that need to use it load it from there. Notably, jbmc does not actually
use it, it just had a spurious include.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 35823a8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96768636
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: e605576).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98334673
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

[tautschnig]

@allredj @peterschrammel @thk123 I guess the TG bot failure is genuine, presumably TG uses remove_asm. Would it be possible to create a TG bump for this please? It should just take an update of the include.

[thk123]

Yeah real bump - will take a look tomorrow.

[thk123]

Got a bump for this sorted.

[tautschnig]

Thanks a lot @thk123. I suppose @peterschrammel should be able to merge both in a co-ordinated fashion when reviewing (and approving) this one.

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 736ebce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98713191
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 117e1e7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98920840
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

[allredj]

TG bump: https://github.com/diffblue/test-gen/pull/2925

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 1286fb6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99015085
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.