Make linter check scenario has tags #3733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge as I've added a commit on to the end demonstrating it catching the problem - will remove once CI fails on it. |
|
Linter fails as expected: https://travis-ci.org/diffblue/cbmc/jobs/477294232 |
added 4 commits
January 9, 2019 15:34
Starting at elided_lines[start_line][linepos] take the end of the line until the ending line.
thk123
force-pushed
the
lint-scenario-has-tags
branch
from
1975c15 to
1b14892
Compare
allredj
reviewed
Jan 10, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 1b14892).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96876363
jeannielynnmoulton
approved these changes
Jan 10, 2019
forejtv
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this (annoyingly) won't report if someone deletes a comma from an existing multi-line test since the error is reported on the line of
SCENARIO/TEST_CASE, which might not be modified. But for the common case that you are adding a new test, it will work.This work was done because it seemed like untagged tests weren't being run, but this doesn't actually seem to be the case. None the less, tests should be tagged per coding guidelines.