Skip to content

fix anonymous struct member initialization #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 8, 2019

The C front-end needs to ignore the unnamed bit-field during struct
initialization; issue #3709.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

(components[entry.index].get_is_padding() ||
components[entry.index].type().id()==ID_code))
components[entry.index].get_anonymous() ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes Struct_Padding1 to fail, which contains an anonymous struct as part of the test. Should this test here be restricted to bitfields?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed -- it should be restricted to scalars.

(components[entry.index].get_is_padding() ||
components[entry.index].type().id()==ID_code))
(components[entry.index].get_anonymous() &&
components[entry.index].type().id() != ID_struct_tag) ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unions should be exempt as well:

#include <assert.h>

struct S
{
  int i;
  union
  {
    int a;
    int b;
  };
  int j;
} s = { 1, { 2 }, 3 };

int main()
{
  assert(s.i == 1);
  assert(s.a == 2);
  assert(s.b == 2);
  assert(s.j == 3);
  return 0;
}

(and it may be worth adding such a test)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

The C front-end needs to ignore the unnamed bit-field during struct
initialization; issue #3709.
@kroening kroening force-pushed the fix-unnamed-member-init branch from 4338b33 to 4548fc1 Compare January 8, 2019 13:23
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 4338b33).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96610343
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@kroening kroening merged commit 3457c46 into develop Jan 8, 2019
@kroening kroening deleted the fix-unnamed-member-init branch January 8, 2019 16:23
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4548fc1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96632876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants