test for bitfield promotion #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jan 8, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
gcc/clang reject bit-fields with bit-width larger than the underlying type. This change enables compilation of the test with gcc/clang.
kroening
force-pushed
the
bitfield-promotion
branch
from
d9c36cb to
d22370b
Compare
allredj
reviewed
Jan 8, 2019
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: d9c36cb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96577049
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Usual promotion rules apply to bit-fields -- thus, an unsigned bit-field that is smaller than 'int' gets promoted to 'int', and thus yields a signed expression. Issue #3709.
kroening
force-pushed
the
bitfield-promotion
branch
from
d22370b to
935a2eb
Compare
allredj
reviewed
Jan 8, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 935a2eb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96581823
tautschnig
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.