Use run instead of popen to run ar [blocks: #3867] #3702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
no-popen
branch
3 times, most recently
from
1e0760a to
e3c6559
Compare
tautschnig
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
force-pushed
the
no-popen
branch
2 times, most recently
from
f93cac6 to
3a38678
Compare
smowton
reviewed
Jan 19, 2019
regression/goto-gcc/CMakeLists.txt
Outdated
| add_custom_command(OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a" | ||
| COMMAND "$<TARGET_FILE_DIR:goto-cc>/goto-gcc" -c foo.c | ||
| COMMAND ${CMAKE_AR} rcs libour_archive.a foo.o | ||
| DEPENDS "$<TARGET_FILE_DIR:goto-cc>/goto-gcc" |
There was a problem hiding this comment.
Ah, thanks, added.
|
(the rest of this is hard for me to review in a timely fashion without reading up a bunch on OSX object formats and such) |
tautschnig
force-pushed
the
no-popen
branch
2 times, most recently
from
eb8ba8b to
5061aca
Compare
Loading files from archives requires the use of ar; invoke it via run instead of popen to eliminate OS-specific code from the goto-cc folder.
tautschnig
force-pushed
the
no-popen
branch
2 times, most recently
from
e8ade2c to
1b947fe
Compare
|
This PR is now restricted to what it said in the subject. Mach-O binary support, which is needed to properly test it in CI, will be done in a separate PR. |
5 tasks
tautschnig
changed the title
allredj
reviewed
Jan 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 1b947fe).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98025595
smowton
approved these changes
Jan 21, 2019
kroening
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading files from archives requires the use of ar; invoke it via run instead of
popen to eliminate OS-specific code from the goto-cc folder.