set_working_directory to wrap chdir #3697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
kroening
reviewed
Jan 6, 2019
| std::string get_current_working_directory(); | ||
| void set_working_directory(const std::string &path); | ||
|
|
There was a problem hiding this comment.
I would probably call that function set_current_path, to mimick the naming in C++17.
kroening
approved these changes
Jan 6, 2019
tautschnig
force-pushed
the
chdir
branch
3 times, most recently
from
bf0613d to
215e79c
Compare
chdir is POSIX and will eventually be implemented via std::filesystem::current_path. Moving this functionality to util helps removing OS-specific parts from other areas of the code base. Furthermore make get_temporary_directory return an absolute, resolved path.
This is a first step to remove the OS-specific code from compile.cpp.
get_temporary_directory fails with an exception in case of problems.
allredj
reviewed
Jan 6, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ce61fda).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96416424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chdir is POSIX and will eventually be implemented via
std::filesystem::current_path. Moving this functionality to util helps removing
OS-specific parts from other areas of the code base.