Skip to content

C library: model _pipe #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

C library: model _pipe #3670

merged 1 commit into from
Jan 4, 2019

Conversation

tautschnig
Copy link
Collaborator

Windows (though not the Windows Runtime) has _pipe to implement pipe.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

chrisr-diffblue
chrisr-diffblue approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable - though I confess that I don't have the most experience of library modelling, or the Windows API....

@kroening kroening removed their assignment Jan 4, 2019
@tautschnig
C library: model _pipe
1a60834 
Windows (though not the Windows Runtime) has _pipe to implement pipe.
allredj
allredj reviewed Jan 4, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1a60834).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96296589

@tautschnig tautschnig merged commit 29a7055 into diffblue:develop Jan 4, 2019
@tautschnig tautschnig deleted the _pipe branch January 4, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@kroening kroening kroening approved these changes

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@tautschnig tautschnig

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tautschnig @smowton @kroening @allredj @chrisr-diffblue