Visual Studio 2017 warns about throwing functions passed to C functions [blocks: #2310]

[tautschnig]

This is done in winbase.h, there is nothing we can do about it.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[smowton]

This suggests we should have a windows.h wrapper for this sort of thing, with a warning push/pop around it?

[tautschnig]

This suggests we should have a windows.h wrapper for this sort of thing, with a warning push/pop around it?

Possible, but I'd rather see us work towards fewer, or more cleanly isolated, OS dependencies. Arguably C++17 would help us a lot with std::filesystem.

[allredj]

✔️
Passed Diffblue compatibility checks (cbmc commit: 3bf5ad0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96377446