Skip to content

Add tag to synthetic type made for String.format() #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2019
Merged

Add tag to synthetic type made for String.format() #3663

merged 1 commit into from
Jan 5, 2019
+1 −0

Conversation

owen-mc-diffblue
Copy link
Contributor

This is needed for a private repository using cbmc, so that we can filter out these types.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

allredj
allredj reviewed Jan 4, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1de1a1d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96280069

Add tag to synthetic type made for String.format()
5ad0480 
Having this type without a tag made it very hard to identify,
e.g. if we want to treat it differently from types which
are not synthetic (i.e. which come directly from the source
code). Compare with refined_string_typet, which has the tag
CPROVER_PREFIX "refined_string_type".
@owen-mc-diffblue owen-mc-diffblue force-pushed the tag-synthetic-type-string-format branch from 1de1a1d to 5ad0480 Compare January 4, 2019 17:02
@owen-mc-diffblue owen-mc-diffblue removed their assignment Jan 4, 2019
@owen-mc-diffblue
Copy link
Contributor Author

I've added more detail to the commit message

allredj
allredj reviewed Jan 4, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 5ad0480).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96330728

@tautschnig tautschnig merged commit e6ce264 into diffblue:develop Jan 5, 2019
@owen-mc-diffblue owen-mc-diffblue deleted the tag-synthetic-type-string-format branch January 7, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@thk123 thk123 Awaiting requested review from thk123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-mc-diffblue @smowton @allredj @tautschnig